[jira] [Comment Edited] (CALCITE-2116) The digests are not same for the common sub-expressions in HepPlanner

["LeoWangLZ (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323510#comment-16323510 ] 

LeoWangLZ edited comment on CALCITE-2116 at 1/12/18 4:05 AM:
-------------------------------------------------------------

[~julianhyde] Thanks
I have another concern about "If a node has only one consumer it would continue to use ListSink."
If we can reuse every HepRelVertex, then one node maybe the input of more than one parents, it's not related with the number of consumer, it depends on the number of parents, if one parent consume the one, then others can't consume it because the input's empty.
I try to write one test that one node have more than one parents.
Suppose If it's no problem, that's great. 


was (Author: perid007):
[~julianhyde] I have another concern about "If a node has only one consumer it would continue to use ListSink."
If we can reuse every HepRelVertex, then one node maybe the input of more than one parents, it's not related with the number of consumer, it depends on the number of parents, if one parent consume the one, then other can't consume it because the input's empty.
I try to write one test that one node have more than one parents.
Suppose If it's no problem, that's great. 

> The digests are not same for the common sub-expressions in HepPlanner
> ---------------------------------------------------------------------
>
>                 Key: CALCITE-2116
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2116
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.15.0
>            Reporter: LeoWangLZ
>            Assignee: Julian Hyde
>             Fix For: 1.16.0
>
>
> The digests are not same for the same sub-query.
> like query
> {code:java}
> select * from (select * from dept union all select * from dept)a;
> {code}
> When run the query, The union relNode has two inputs, and it's same expectly and it's the same object instead of the print of plan, but Now they are not same.
> And for Test testReplaceCommonSubexpression, the rule is only firing once, but now it's two.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)