You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/22 08:10:08 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request #18: ARROW-12504: Buffer::from_slice_ref set correct capacity
tustvold opened a new pull request #18:
URL: https://github.com/apache/arrow-rs/pull/18
A minor change, that quite possibly makes no performance difference in practice, as the subsequent call to extend_from_slice calls reserve with the correct data size, but thought it couldn't hurt to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao commented on pull request #18: ARROW-12504: Buffer::from_slice_ref set correct capacity
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #18:
URL: https://github.com/apache/arrow-rs/pull/18#issuecomment-824827737
Yeap, makes a lot of sense; great catch 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao merged pull request #18: ARROW-12504: Buffer::from_slice_ref set correct capacity
Posted by GitBox <gi...@apache.org>.
jorgecarleitao merged pull request #18:
URL: https://github.com/apache/arrow-rs/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #18: ARROW-12504: Buffer::from_slice_ref set correct capacity
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #18:
URL: https://github.com/apache/arrow-rs/pull/18#issuecomment-824818074
@jorgecarleitao can you take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org