[jira] [Commented] (FLINK-10399) Refractor ParameterTool#fromArgs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641331#comment-16641331 ] 

ASF GitHub Bot commented on FLINK-10399:
----------------------------------------

TisonKun commented on issue #6737: [FLINK-10399] Refractor ParameterTool#fromArgs
URL: https://github.com/apache/flink/pull/6737#issuecomment-427716737
 
 
   ping @GJL as a reminder :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refractor ParameterTool#fromArgs
> --------------------------------
>
>                 Key: FLINK-10399
>                 URL: https://issues.apache.org/jira/browse/FLINK-10399
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.7.0
>            Reporter: tison
>            Assignee: tison
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> {{ParameterTool#fromArgs}} uses a weird implement which flink developer would fail to parse it fast.
> The main problem is that, when parse args, we always try to get a key-value pair, but the implement iterate by a {{for}} loop, thus introduce weird flag/mutable variable and branches.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)