You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/11 20:41:13 UTC
[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4304: ValidationException on metadata-only delete with presence of certain delete files
RussellSpitzer commented on a change in pull request #4304:
URL: https://github.com/apache/iceberg/pull/4304#discussion_r825083308
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -359,7 +359,13 @@ private boolean manifestHasDeletedFiles(PartitionAndMetricsEvaluator evaluator,
boolean fileDelete = deletePaths.contains(file.path()) ||
dropPartitions.contains(file.specId(), file.partition()) ||
(isDelete && entry.sequenceNumber() > 0 && entry.sequenceNumber() < minSequenceNumber);
+
if (fileDelete || evaluator.rowsMightMatch(file)) {
+ if (!fileDelete && !file.content().equals(FileContent.DATA) && !evaluator.rowsMustMatch(file)) {
Review comment:
I think if we can I would un-nest this clause and assign it to a variable describing what we are checking here (much like fileDelete) above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org