[GitHub] [superset] cccs-Dustin edited a comment on pull request #19120: feat: Edit columns in new dataset editor

[GitBox <gi...@apache.org>]

cccs-Dustin edited a comment on pull request #19120:
URL: https://github.com/apache/superset/pull/19120#issuecomment-1069146329


   After some investigation, it turns out that the issue we were running into can be solved one of two ways. The first of the two ways is to cast the variable in the virtual dataset SQL statement to avoid it being assigned the wrong data type.
   
   The second way to avoid the issue mentioned in the use case was actually solved by this PR: https://github.com/apache/superset/pull/17360/files. Instead of having the column type set to be a maximum of 32 characters, it switches the type to TEXT which does not have a limit. 
   
   Since the issue can now be avoided without having to make modifications to the code, we decided to close this PR (and the corresponding issue).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org