[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

[GitBox <gi...@apache.org>]

magibney commented on a change in pull request #592:
URL: https://github.com/apache/solr/pull/592#discussion_r798151164



##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -2040,19 +2098,7 @@ protected void sortDocSet(QueryResult qr, QueryCommand cmd) throws IOException {
       leafCollector.collect(doc - base);

Review comment:
       @sonatype-lift ignore
   This is actually a revert, so unrelated to this PR; in any event I trust this will not manifest in practice as an NPE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org