[GitHub] astefanutti commented on issue #375: Jolokia trait initial implementation

[GitBox <gi...@apache.org>]

astefanutti commented on issue #375: Jolokia trait initial implementation
URL: https://github.com/apache/camel-k/pull/375#issuecomment-457287928
 
 
   > Another option would be to add a boolean like agent-enabled with false as
   default value. then disable the trait only when it is explicit disabled
   (like other trait do)
   
   After a second look at it, the `Configure` method could always return `true` irrespective of the `enabled` property and do the logic in the `Apply` method. So my initial understanding was not correct!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services