[GitHub] [skywalking] pg-yang commented on a diff in pull request #10437: Fix wrong time for OTEL mock service, invalid condition(ge 0) for e2e cases

["pg-yang (via GitHub)" <gi...@apache.org>]

pg-yang commented on code in PR #10437:
URL: https://github.com/apache/skywalking/pull/10437#discussion_r1115844435


##########
test/e2e-v2/cases/win/expected/metrics-has-value.yml:
##########
@@ -15,5 +15,5 @@
 
   {{- contains . }}
 - key: {{ notEmpty .key }}
-  value: {{ gt .value 0 }}
+  value: {{ ge .value 1 }}

Review Comment:
   When using `gt 0`, will encounter error:
   
   ```
    DETAILS  failed to verify the output: swctl --display yaml --base-url=http://${oap_host}:${oap_12800}/graphql metrics linear --name=meter_win_memory_swap_total --service-name=10.211.55.3 | yq e 'to_entries' -, error:                                                                                        
             failed to execute template: template: test:18:12: executing "test" at <gt .value 0>: error calling gt: incompatible types for comparison
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org