You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/05 17:02:27 UTC

[GitHub] [qpid-proton] jiridanek opened a new pull request #259: PROTON-2220: smarter accounting for file descriptors in tests

jiridanek opened a new pull request #259:
URL: https://github.com/apache/qpid-proton/pull/259


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter commented on pull request #259: PROTON-2220: smarter accounting for file descriptors in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #259:
URL: https://github.com/apache/qpid-proton/pull/259#issuecomment-639678253


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=h1) Report
   > Merging [#259](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/259/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #259      +/-   ##
   ==========================================
   + Coverage   83.05%   83.17%   +0.12%     
   ==========================================
     Files         338      339       +1     
     Lines       41431    41519      +88     
   ==========================================
   + Hits        34410    34534     +124     
   + Misses       7021     6985      -36     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5) | `90.52% <75.00%> (-0.69%)` | :arrow_down: |
   | [...on/test\_PROTON\_2121\_blocking\_connection\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzIxMjFfYmxvY2tpbmdfY29ubmVjdGlvbl9mZF9sZWFrLnB5) | `94.89% <100.00%> (ø)` | |
   | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.21% <0.00%> (-0.06%)` | :arrow_down: |
   | [ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=) | `95.55% <0.00%> (ø)` | |
   | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.61% <0.00%> (+0.31%)` | :arrow_up: |
   | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `82.75% <0.00%> (+1.48%)` | :arrow_up: |
   | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `96.10% <0.00%> (+3.89%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=footer). Last update [65a5d9e...6e5f13d](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #259: PROTON-2220: smarter accounting for file descriptors in tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #259:
URL: https://github.com/apache/qpid-proton/pull/259#issuecomment-639678253


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=h1) Report
   > Merging [#259](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/65a5d9e837cf8de3024e7039dc7f5f2175d13461&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/259/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #259      +/-   ##
   ==========================================
   + Coverage   83.05%   83.17%   +0.12%     
   ==========================================
     Files         338      339       +1     
     Lines       41431    41519      +88     
   ==========================================
   + Hits        34410    34534     +124     
   + Misses       7021     6985      -36     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...on/test\_PROTON\_1800\_syncrequestresponse\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE4MDBfc3luY3JlcXVlc3RyZXNwb25zZV9mZF9sZWFrLnB5) | `90.52% <75.00%> (-0.69%)` | :arrow_down: |
   | [...on/test\_PROTON\_2121\_blocking\_connection\_fd\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzIxMjFfYmxvY2tpbmdfY29ubmVjdGlvbl9mZF9sZWFrLnB5) | `94.89% <100.00%> (ø)` | |
   | [c/tests/threaderciser.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy90ZXN0cy90aHJlYWRlcmNpc2VyLmM=) | `83.21% <0.00%> (-0.06%)` | :arrow_down: |
   | [ruby/tests/test\_interop.rb](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cnVieS90ZXN0cy90ZXN0X2ludGVyb3AucmI=) | `95.55% <0.00%> (ø)` | |
   | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.61% <0.00%> (+0.31%)` | :arrow_up: |
   | [c/src/proactor/epoll.c](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvZXBvbGwuYw==) | `82.75% <0.00%> (+1.48%)` | :arrow_up: |
   | [ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/259/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `96.10% <0.00%> (+3.89%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=footer). Last update [65a5d9e...6e5f13d](https://codecov.io/gh/apache/qpid-proton/pull/259?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek merged pull request #259: PROTON-2220: smarter accounting for file descriptors in tests

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #259:
URL: https://github.com/apache/qpid-proton/pull/259


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org