[jira] [Commented] (FALCON-2336) StartupProperties shouldn't have specific logic to handle safemode property.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440679#comment-16440679 ] 

ASF GitHub Bot commented on FALCON-2336:
----------------------------------------

GitHub user pallavi-rao opened a pull request:

    https://github.com/apache/falcon/pull/410

    FALCON-2336 StartupProperties shouldn't have specific logic to handle…

    … safemode property

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pallavi-rao/falcon 2336

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/falcon/pull/410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #410
    
----
commit 95f1db26b00619f3bc0a03b6916260e2b80b716c
Author: pallavi-rao <pa...@...>
Date:   2018-04-17T09:50:41Z

    FALCON-2336 StartupProperties shouldn't have specific logic to handle safemode property

----


> StartupProperties shouldn't have specific logic to handle safemode property.
> ----------------------------------------------------------------------------
>
>                 Key: FALCON-2336
>                 URL: https://issues.apache.org/jira/browse/FALCON-2336
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Pallavi Rao
>            Assignee: Pallavi Rao
>            Priority: Minor
>
> Two problems with that:
>  # Violation of class responsibility - Falcon Server is already handling the safemode prop and any related code should be there.
>  # If Hadoop is secure, the server won't start without an explicit kinit before server start as server won't have credentials to talk to Hadoop yet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)