You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/12 07:13:21 UTC

[GitHub] [flink] 1u0 commented on issue #9021: [FLINK-13205][runtime] Make checkpoints injection ordered with stop-with-savepoint

1u0 commented on issue #9021: [FLINK-13205][runtime] Make checkpoints injection ordered with stop-with-savepoint
URL: https://github.com/apache/flink/pull/9021#issuecomment-510775742
 
 
   I think the `finishTask()` doesn't need to be run with acquired `checkpointLock`. The reason is the same as for `cancelTask()` invocation in `cancel()` - currently, both invocations should have the same expectations in regard of holding the lock. So far, the `cancelTask()` call wasn't called under `checkpointLock`.
   
   What I'm not sure about, if the modified `StreamTask.notifyCheckpointComplete()` should be called within `SafetyNetCloseableRegistry` context or with `Task.closeNetworkResources()` call afterwards.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services