You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/08 16:05:57 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #7665:
[WiP] [api] [database] New, migrate to new FAB API side by side
codecov-io edited a comment on issue #7665: [WiP] [api] [database] New, migrate to new FAB API side by side
URL: https://github.com/apache/incubator-superset/pull/7665#issuecomment-509288428
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=h1) Report
> Merging [#7665](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d08efd39d34bfc53fcc18c33b6761add4860cb7a?src=pr&el=desc) will **increase** coverage by `8.06%`.
> The diff coverage is `76.76%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7665 +/- ##
==========================================
+ Coverage 65.89% 73.95% +8.06%
==========================================
Files 459 109 -350
Lines 22023 11557 -10466
Branches 2418 0 -2418
==========================================
- Hits 14512 8547 -5965
+ Misses 7391 3010 -4381
+ Partials 120 0 -120
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `0% <0%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `94.04% <100%> (+0.03%)` | :arrow_up: |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <100%> (+3.65%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.33% <100%> (-0.49%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `81.25% <81.25%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `91.11% <91.11%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `72.72% <0%> (-22.73%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| ... and [353 more](https://codecov.io/gh/apache/incubator-superset/pull/7665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=footer). Last update [d08efd3...e53fe90](https://codecov.io/gh/apache/incubator-superset/pull/7665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org