[jira] [Commented] (DRILL-362) Some protobuf enum values generates problematic C++/Windows code

["Jacques Nadeau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011784#comment-14011784 ] 

Jacques Nadeau commented on DRILL-362:
--------------------------------------

C++ client has script as workaround rather than changing all codebase.

> Some protobuf enum values generates problematic C++/Windows code
> ----------------------------------------------------------------
>
>                 Key: DRILL-362
>                 URL: https://issues.apache.org/jira/browse/DRILL-362
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: George Chow
>            Priority: Minor
>
> The enums DataMode and MinorType (in Types.proto) each contain a value (OPTIONAL and NULL respectively) that generate into problematic C++ code on Windows under Visual Studio.
> I propose to add a prefix to the enum values to uniquify them. For example:
> enum DataMode {
>   DM_OPTIONAL = 0,
>   DM_REQUIRED = 1,
>   DM_REPEATED = 2
> }
> This is slightly ugly but is ultimately safe. Unfortunately, this change will trigger a lot of little changes throughout the codebase.



--
This message was sent by Atlassian JIRA
(v6.2#6252)