[GitHub] [maven] AlexanderAshitkin commented on a change in pull request #604: Finish switch to modello

[GitBox <gi...@apache.org>]

AlexanderAshitkin commented on a change in pull request #604:
URL: https://github.com/apache/maven/pull/604#discussion_r744833887



##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecycleExecutionPlanCalculator.java
##########
@@ -554,6 +554,8 @@ private void injectLifecycleOverlay( Map<String, List<MojoExecution>> lifecycleM
 
         MojoExecution forkedExecution = new MojoExecution( forkedMojoDescriptor, forkedGoal );
 
+        forkedExecution.setLifecyclePhase( mojoExecution.getLifecyclePhase() );

Review comment:
       Hi
   Thanks for the change! Jaxb is gone for the good. In overall pr looks good for me.
   Few notes: 
   1. as i understand modello schema is located in core. if we move the cache to an extension in future - doest it mean there will be dependency on core from the extension? Looks like modello scheme actuall couples the cache and the core.
   2 There should be few small jaxb related leftovers - dependency in pom itself and in licenses, but in general it looks good.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org