You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "mrhbj (via GitHub)" <gi...@apache.org> on 2024/08/02 09:45:18 UTC
[PR] These attributes are better for the final state(#13628) [lucene]
mrhbj opened a new pull request, #13630:
URL: https://github.com/apache/lucene/pull/13630
These attributes are better for the final state(#13628)
### Description
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller closed pull request #13630: These attributes are better for the final state(#13628)
URL: https://github.com/apache/lucene/pull/13630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "mrhbj (via GitHub)" <gi...@apache.org>.
mrhbj commented on code in PR #13630:
URL: https://github.com/apache/lucene/pull/13630#discussion_r1713395891
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java:
##########
@@ -46,8 +46,8 @@
* uptos(position, payload). 4. start offset.
*/
public final class Lucene99SkipWriter extends MultiLevelSkipListWriter {
- private int[] lastSkipDoc;
- private long[] lastSkipDocPointer;
+ private final int[] lastSkipDoc;
+ private final long[] lastSkipDocPointer;
private long[] lastSkipPosPointer;
private long[] lastSkipPayPointer;
Review Comment:
@gsmiller I have did that in #13639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #13630:
URL: https://github.com/apache/lucene/pull/13630#issuecomment-2284113028
Closing in favor of #13639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "mrhbj (via GitHub)" <gi...@apache.org>.
mrhbj commented on PR #13630:
URL: https://github.com/apache/lucene/pull/13630#issuecomment-2278184332
ok i will do this
---Original---
From: "Greg ***@***.***>
Date: Fri, Aug 9, 2024 23:12 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/lucene] These attributes are better for the finalstate(#13628) (PR #13630)
@gsmiller commented on this pull request.
In lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java:
> private long[] lastSkipPosPointer; private long[] lastSkipPayPointer;
@mrhbj were you planning to push an update to this PR that also marks these fields final? Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on code in PR #13630:
URL: https://github.com/apache/lucene/pull/13630#discussion_r1701964276
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java:
##########
@@ -46,8 +46,8 @@
* uptos(position, payload). 4. start offset.
*/
public final class Lucene99SkipWriter extends MultiLevelSkipListWriter {
- private int[] lastSkipDoc;
- private long[] lastSkipDocPointer;
+ private final int[] lastSkipDoc;
+ private final long[] lastSkipDocPointer;
private long[] lastSkipPosPointer;
private long[] lastSkipPayPointer;
Review Comment:
We can make these final too if we tidy the ctor a little bit. Let's go ahead and do this if we're doing a pass on marking fields `final`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] These attributes are better for the final state(#13628) [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on code in PR #13630:
URL: https://github.com/apache/lucene/pull/13630#discussion_r1711652689
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene99/Lucene99SkipWriter.java:
##########
@@ -46,8 +46,8 @@
* uptos(position, payload). 4. start offset.
*/
public final class Lucene99SkipWriter extends MultiLevelSkipListWriter {
- private int[] lastSkipDoc;
- private long[] lastSkipDocPointer;
+ private final int[] lastSkipDoc;
+ private final long[] lastSkipDocPointer;
private long[] lastSkipPosPointer;
private long[] lastSkipPayPointer;
Review Comment:
@mrhbj were you planning to push an update to this PR that also marks these fields `final`? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org