[GitHub] [incubator-linkis] casionone commented on a diff in pull request #1942: EC supports add taskIDs into the underlying engine's conf

[GitBox <gi...@apache.org>]

casionone commented on code in PR #1942:
URL: https://github.com/apache/incubator-linkis/pull/1942#discussion_r848321726


##########
linkis-engineconn-plugins/engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/executor/HiveEngineConnExecutor.scala:
##########
@@ -120,6 +121,11 @@ class HiveEngineConnExecutor(id: Int,
     currentSqlProgress = 0.0f
     val realCode = code.trim()
     LOG.info(s"hive client begins to run hql code:\n ${realCode.trim}")
+    val jobId = JobUtils.getJobIdFromMap(engineExecutorContext.getProperties)
+    if (StringUtils.isNotBlank(jobId)) {
+      LOG.info(s"set apred.job.name=$jobId")

Review Comment:
   ```
   LOG.info(s"set apred.job.name=$jobId") 
   LOG.info(s"set mapred.job.name=$jobId") ?
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org