You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/22 06:10:57 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #12120: Avoid trying to refresh MetadataCaches when we're disconnected from ZK

merlimat commented on a change in pull request #12120:
URL: https://github.com/apache/pulsar/pull/12120#discussion_r713619581



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
##########
@@ -65,6 +67,9 @@
     private final AsyncLoadingCache<String, Boolean> existsCache;
     private final CopyOnWriteArrayList<MetadataCacheImpl<?>> metadataCaches = new CopyOnWriteArrayList<>();
 
+    @Getter
+    private boolean isConnected = true;

Review comment:
       I was trying to avoid extra overhead here since we don't need exact consistent behavior here. This is a best-effort tentative to avoid the refreshes, to avoid printing the cache reloading exceptions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org