[GitHub] [incubator-druid] glasser commented on a change in pull request #8546: add support for dogstatsd events in statsd-emitter

[GitBox <gi...@apache.org>]

glasser commented on a change in pull request #8546: add support for dogstatsd events in statsd-emitter
URL: https://github.com/apache/incubator-druid/pull/8546#discussion_r325018561
 
 

 ##########
 File path: extensions-contrib/statsd-emitter/src/main/java/org/apache/druid/emitter/statsd/StatsDEmitter.java
 ##########
 @@ -174,6 +177,59 @@ public void emit(Event event)
       } else {
         log.debug("Service=[%s], Metric=[%s] has no StatsD type mapping", service, metric);
       }
+    } else if (event instanceof AlertEvent && config.isDogstatsd()) {
 
 Review comment:
   Do you think it might be reasonable to allow users to enable metrics and events separately? eg, to turn off event emitting if you're not using it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org