You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2022/05/03 20:45:05 UTC

[VOTE] Release Apache Tomcat Native 1.2.33

Version 1.2.33 includes the following changes compared to 1.2.32

- Updated recommended minimum OpenSSL to 1.1.1o and build windows
   binaries using that version

- Fix BZ 66035, a crash when attempting to read the TSL session ID after
   a failed handshake

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.33 release is
  [ ] Stable, go ahead and release
  [ ] Broken because of ...

Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.33
[2]
https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=5806305d98ef24f60ea1a4d8c99ef29e6faab434

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.2.33

Posted by Mark Thomas <ma...@apache.org>.
On 04/05/2022 15:54, Christopher Schultz wrote:
> Mark,
> 
> Thanks for RM'ing
> 
> On 5/3/22 16:45, Mark Thomas wrote:
>> Version 1.2.33 includes the following changes compared to 1.2.32
>>
>> - Updated recommended minimum OpenSSL to 1.1.1o and build windows
>>    binaries using that version
>>
>> - Fix BZ 66035, a crash when attempting to read the TSL session ID after
>>    a failed handshake
>>
>> The proposed release artefacts can be found at [1],
>> and the build was done using tag [2].
>>
>> The Apache Tomcat Native 1.2.33 release is
>>   [X] Stable, go ahead and release
>>   [ ] Broken because of ...
> 
> Builds cleanly on MacOS and Debian Linux.
> 
> Some notes:
> 
> The binary built on MacOS ends up with file names libtcnative-1.0.dylib 
> (and friends) instead of libtcnative-1.2.dylib or -1.2.33.dylib, etc. Is 
> that expected? On Linux the binaries are called libtcnative-1.so.0.2.33 
> (and friends).

No idea. I'm fairly sure I didn't change anything that would impact 
that. I've no objection to the version numbers being made consistent.

> When adding CFLAGS=-Wall -pedantic -ansi I get some errors from both gcc 
> and clang. We should probably spend some time cleaning that stuff up. 
> Lots of this is due to use of "long long" which is of course required, 
> so I'll try to tighten things up a bit myself.

Tx.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.2.33

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

Thanks for RM'ing

On 5/3/22 16:45, Mark Thomas wrote:
> Version 1.2.33 includes the following changes compared to 1.2.32
> 
> - Updated recommended minimum OpenSSL to 1.1.1o and build windows
>    binaries using that version
> 
> - Fix BZ 66035, a crash when attempting to read the TSL session ID after
>    a failed handshake
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.33 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...

Builds cleanly on MacOS and Debian Linux.

Some notes:

The binary built on MacOS ends up with file names libtcnative-1.0.dylib 
(and friends) instead of libtcnative-1.2.dylib or -1.2.33.dylib, etc. Is 
that expected? On Linux the binaries are called libtcnative-1.so.0.2.33 
(and friends).

When adding CFLAGS=-Wall -pedantic -ansi I get some errors from both gcc 
and clang. We should probably spend some time cleaning that stuff up. 
Lots of this is due to use of "long long" which is of course required, 
so I'll try to tighten things up a bit myself.

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.2.33

Posted by Igal Sapir <is...@apache.org>.
On Tue, May 3, 2022 at 1:45 PM Mark Thomas <ma...@apache.org> wrote:

> Version 1.2.33 includes the following changes compared to 1.2.32
>
> - Updated recommended minimum OpenSSL to 1.1.1o and build windows
>    binaries using that version
>
> - Fix BZ 66035, a crash when attempting to read the TSL session ID after
>    a failed handshake
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.33 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

Built from source and passed APR unit tests on Ubuntu with Java 11

Igal



>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.33
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=5806305d98ef24f60ea1a4d8c99ef29e6faab434
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

[VOTE][RESULT] Release Apache Tomcat Native 1.2.33

Posted by Mark Thomas <ma...@apache.org>.
The following votes were cast:

Binding:
+1: isapir, markt, schultz

No other votes were cast.

The vote therefore passes.

Thanks to everyone who contributed to this release.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.2.33

Posted by Mark Thomas <ma...@apache.org>.
On 03/05/2022 21:45, Mark Thomas wrote:
> Version 1.2.33 includes the following changes compared to 1.2.32
> 
> - Updated recommended minimum OpenSSL to 1.1.1o and build windows
>    binaries using that version
> 
> - Fix BZ 66035, a crash when attempting to read the TSL session ID after
>    a failed handshake
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.33 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...

Tested with 10.1.x on Linux (built with OpenSSL 1.1.1 HEAD) and Windows 
(tested with convenience binary) and all tests pass.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org