You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by keith-turner <gi...@git.apache.org> on 2017/04/26 23:29:19 UTC
[GitHub] incubator-fluo-recipes pull request #129: Reduced creation of intermediate S...
GitHub user keith-turner opened a pull request:
https://github.com/apache/incubator-fluo-recipes/pull/129
Reduced creation of intermediate String and byte arrays
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keith-turner/fluo-recipes reduce_copies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fluo-recipes/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit 0cda5ae9ccb43497e43ef48d8651dfd969e5d085
Author: Keith Turner <kt...@apache.org>
Date: 2017-04-26T22:21:27Z
Reduced creation of intermediate String and byte arrays
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes pull request #129: Reduced creation of intermediate S...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-recipes/pull/129#discussion_r113977876
--- Diff: modules/core/src/main/java/org/apache/fluo/recipes/core/map/CollisionFreeMap.java ---
@@ -194,12 +199,11 @@ void process(TransactionBase tx, Bytes ntfyRow, Column col) throws Exception {
tx.setWeakNotification(ntfyRow, col);
}
- byte[] dataPrefix = ntfyRow.toArray();
--- End diff --
Does `ntfyRow` contain `mapId`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes pull request #129: Reduced creation of intermediate S...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-fluo-recipes/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-recipes pull request #129: Reduced creation of intermediate S...
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-recipes/pull/129#discussion_r113979089
--- Diff: modules/core/src/main/java/org/apache/fluo/recipes/core/map/CollisionFreeMap.java ---
@@ -194,12 +199,11 @@ void process(TransactionBase tx, Bytes ntfyRow, Column col) throws Exception {
tx.setWeakNotification(ntfyRow, col);
}
- byte[] dataPrefix = ntfyRow.toArray();
--- End diff --
It should. I added a sanity check at the beginning of process to ensure it starts with updatePrefix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---