[jira] [Commented] (ARROW-1722) [C++] Add linting script to look for C++/CLI issues

["Antoine Pitrou (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299775#comment-17299775 ] 

Antoine Pitrou commented on ARROW-1722:
---------------------------------------

[~wesm] [~tobyshaw] Can you add more context on these exclusions?
While the nullptr case is easy to avoid using the NULLPTR macro, the mutex exclusion is potentially annoying.

> [C++] Add linting script to look for C++/CLI issues
> ---------------------------------------------------
>
>                 Key: ARROW-1722
>                 URL: https://issues.apache.org/jira/browse/ARROW-1722
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.10.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This includes:
> * Using {{nullptr}} in header files (we must instead use an appropriate macro to use {{__nullptr}} when the host compiler is C++/CLI)
> * Including {{<mutex>}} in a public header (e.g. header files without "impl" or "internal" in their name)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)