You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Matt Ryan (JIRA)" <ji...@apache.org> on 2016/12/20 22:15:59 UTC

[jira] [Commented] (OAK-5357) StringUtils conversion functions can throw NullPointerException

    [ https://issues.apache.org/jira/browse/OAK-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765405#comment-15765405 ] 

Matt Ryan commented on OAK-5357:
--------------------------------

I'm okay with just throwing NPE automatically from these functions also - but I'd like to see the unit test exercise this explicitly so it is clear by looking at the code what we expected to happen in that case.

> StringUtils conversion functions can throw NullPointerException
> ---------------------------------------------------------------
>
>                 Key: OAK-5357
>                 URL: https://issues.apache.org/jira/browse/OAK-5357
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: commons
>    Affects Versions: 1.5.16
>            Reporter: Matt Ryan
>            Priority: Minor
>         Attachments: OAK-5357.1.patch
>
>
> In the {{StringUtils}} class in {{oak-commons}}, the methods {{convertBytesToHex()}} and {{convertHexToBytes()}} can throw NullPointerException if the argument passed in is null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)