You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/29 20:56:34 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request, #6954: libc: Port strtod fixes to strtof, strtold and improve comments

hartmannathan opened a new pull request, #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954

   ## Summary
   
   Port the changes of PR #6952 to strtof() and strtold().
   
   Also add a note of our implementation's limitations compared to POSIX.
   
   ## Impact
   
   Consistency between strtod(), strtof(), strtold().
   
   Improved documentation.
   
   ## Testing
   
   Build testing and nxstyle.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #6954: libc: Port strtod fixes to strtof, strtold and improve comments

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954#issuecomment-1231527162

   > @hartmannathan I had a look, and it seems perfect.
   > 
   > 
   > 
   > I did try all the test strings on `strtof()` and `strtold()` and they all succeeded.
   
   @fjpanag thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6954: libc: Port strtod fixes to strtof, strtold and improve comments

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #6954: libc: Port strtod fixes to strtof, strtold and improve comments

Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #6954:
URL: https://github.com/apache/incubator-nuttx/pull/6954#issuecomment-1231496014

   @hartmannathan I had a look, and it seems perfect.
   
   I did try all the test strings on `strtof()` and `strtold()` and they all succeeded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org