You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by nk...@apache.org on 2019/11/13 14:18:19 UTC

[flink] 01/02: [hotfix][docs] clarify RocksDB thread options applicability per operator/TM

This is an automated email from the ASF dual-hosted git repository.

nkruber pushed a commit to branch release-1.8
in repository https://gitbox.apache.org/repos/asf/flink.git

commit db552a1a66b60e24e6c13f972d72fa065ce02548
Author: Nico Kruber <ni...@ververica.com>
AuthorDate: Tue Nov 12 15:07:20 2019 +0100

    [hotfix][docs] clarify RocksDB thread options applicability per operator/TM
---
 docs/_includes/generated/rocks_db_configurable_configuration.html     | 4 ++--
 docs/_includes/generated/rocks_db_configuration.html                  | 2 +-
 .../flink/contrib/streaming/state/RocksDBConfigurableOptions.java     | 4 ++--
 .../java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/_includes/generated/rocks_db_configurable_configuration.html b/docs/_includes/generated/rocks_db_configurable_configuration.html
index 638a3a5..fa0e0ff 100644
--- a/docs/_includes/generated/rocks_db_configurable_configuration.html
+++ b/docs/_includes/generated/rocks_db_configurable_configuration.html
@@ -40,12 +40,12 @@
         <tr>
             <td><h5>state.backend.rocksdb.files.open</h5></td>
             <td style="word-wrap: break-word;">(none)</td>
-            <td>The maximum number of open files that can be used by the DB, '-1' means no limit. RocksDB has default configuration as '5000'.</td>
+            <td>The maximum number of open files (per TaskManager) that can be used by the DB, '-1' means no limit. RocksDB has default configuration as '5000'.</td>
         </tr>
         <tr>
             <td><h5>state.backend.rocksdb.thread.num</h5></td>
             <td style="word-wrap: break-word;">(none)</td>
-            <td>The maximum number of concurrent background flush and compaction jobs. RocksDB has default configuration as '1'.</td>
+            <td>The maximum number of concurrent background flush and compaction jobs (per TaskManager). RocksDB has default configuration as '1'.</td>
         </tr>
         <tr>
             <td><h5>state.backend.rocksdb.writebuffer.count</h5></td>
diff --git a/docs/_includes/generated/rocks_db_configuration.html b/docs/_includes/generated/rocks_db_configuration.html
index 88e8c46..f9a6d95 100644
--- a/docs/_includes/generated/rocks_db_configuration.html
+++ b/docs/_includes/generated/rocks_db_configuration.html
@@ -10,7 +10,7 @@
         <tr>
             <td><h5>state.backend.rocksdb.checkpoint.transfer.thread.num</h5></td>
             <td style="word-wrap: break-word;">1</td>
-            <td>The number of threads used to transfer (download and upload) files in RocksDBStateBackend.</td>
+            <td>The number of threads (per stateful operator) used to transfer (download and upload) files in RocksDBStateBackend.</td>
         </tr>
         <tr>
             <td><h5>state.backend.rocksdb.localdir</h5></td>
diff --git a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
index 089f08c..261e5f0 100644
--- a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
+++ b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
@@ -46,13 +46,13 @@ public class RocksDBConfigurableOptions implements Serializable {
 	public static final ConfigOption<String> MAX_BACKGROUND_THREADS =
 		key("state.backend.rocksdb.thread.num")
 			.noDefaultValue()
-			.withDescription("The maximum number of concurrent background flush and compaction jobs. " +
+			.withDescription("The maximum number of concurrent background flush and compaction jobs (per TaskManager). " +
 				"RocksDB has default configuration as '1'.");
 
 	public static final ConfigOption<String> MAX_OPEN_FILES =
 		key("state.backend.rocksdb.files.open")
 			.noDefaultValue()
-			.withDescription("The maximum number of open files that can be used by the DB, '-1' means no limit. " +
+			.withDescription("The maximum number of open files (per TaskManager) that can be used by the DB, '-1' means no limit. " +
 				"RocksDB has default configuration as '5000'.");
 
 	//--------------------------------------------------------------------------
diff --git a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
index 8fa497b..8ffd142 100644
--- a/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
+++ b/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
@@ -56,7 +56,7 @@ public class RocksDBOptions {
 	public static final ConfigOption<Integer> CHECKPOINT_TRANSFER_THREAD_NUM = ConfigOptions
 		.key("state.backend.rocksdb.checkpoint.transfer.thread.num")
 		.defaultValue(1)
-		.withDescription("The number of threads used to transfer (download and upload) files in RocksDBStateBackend.");
+		.withDescription("The number of threads (per stateful operator) used to transfer (download and upload) files in RocksDBStateBackend.");
 
 	/** This determines if compaction filter to cleanup state with TTL is enabled. */
 	public static final ConfigOption<Boolean> TTL_COMPACT_FILTER_ENABLED = ConfigOptions