[jira] [Commented] (ORC-91) Use hdfs v-blocks instead of zero-padding stripes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115000#comment-16115000 ] 

ASF GitHub Bot commented on ORC-91:
-----------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/138#discussion_r131491100
  
    --- Diff: java/core/src/java/org/apache/orc/impl/HadoopShims.java ---
    @@ -124,6 +126,43 @@
        */
       public TextReaderShim getTextReaderShim(InputStream input) throws IOException;
     
    +  
    +  /** 
    +   * Block filler shim - make sure the DFS blocks ends at this offset.
    +   */
    +  public interface BlockFillerShim {
    --- End diff --
    
    I think it would be better to create a HadoopShims_2_5 that has the simple fill method and make HadoopShimsCurrent have the full featured one.


> Use hdfs v-blocks instead of zero-padding stripes
> -------------------------------------------------
>
>                 Key: ORC-91
>                 URL: https://issues.apache.org/jira/browse/ORC-91
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Gopal V
>            Assignee: Gopal V
>
> HDFS-3689 added variable length blocks to HDFS as a core feature.
> hsync(SyncFlag.END_BLOCK) 
> can now end an HDFS block on disk without padding it out with zeros. 
> The current space wasted in ORC to padding is 5%.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)