You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2017/03/12 08:12:41 UTC
Review Request 57543: When agent retries commands it needs to handle
credential store processing correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/
-----------------------------------------------------------
Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
Bugs: AMBARI-20407
https://issues.apache.org/jira/browse/AMBARI-20407
Repository: ambari
Description
-------
When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
Diff: https://reviews.apache.org/r/57543/diff/1/
Testing
-------
Ran unit tests locally
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [4.014s]
[INFO] utility ........................................... SUCCESS [1.311s]
[INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
[INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Thanks,
Sumit Mohanty
Re: Review Request 57543: When agent retries commands it needs to
handle credential store processing correctly
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/#review168815
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On March 12, 2017, 4:12 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57543/
> -----------------------------------------------------------
>
> (Updated March 12, 2017, 4:12 a.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20407
> https://issues.apache.org/jira/browse/AMBARI-20407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57543/diff/1/
>
>
> Testing
> -------
>
> Ran unit tests locally
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.014s]
> [INFO] utility ........................................... SUCCESS [1.311s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 57543: When agent retries commands it needs to
handle credential store processing correctly
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/#review168811
-----------------------------------------------------------
Ship it!
- Madhuvanthi Radhakrishnan
On March 12, 2017, 8:12 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57543/
> -----------------------------------------------------------
>
> (Updated March 12, 2017, 8:12 a.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20407
> https://issues.apache.org/jira/browse/AMBARI-20407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57543/diff/1/
>
>
> Testing
> -------
>
> Ran unit tests locally
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.014s]
> [INFO] utility ........................................... SUCCESS [1.311s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 57543: When agent retries commands it needs to
handle credential store processing correctly
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/#review168817
-----------------------------------------------------------
Ship it!
Ship It!
- Swapan Shridhar
On March 12, 2017, 8:12 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57543/
> -----------------------------------------------------------
>
> (Updated March 12, 2017, 8:12 a.m.)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20407
> https://issues.apache.org/jira/browse/AMBARI-20407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57543/diff/1/
>
>
> Testing
> -------
>
> Ran unit tests locally
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.014s]
> [INFO] utility ........................................... SUCCESS [1.311s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 57543: When agent retries commands it needs to
handle credential store processing correctly
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/#review168813
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 12, 2017, 8:12 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57543/
> -----------------------------------------------------------
>
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 12, 2017, 8:12 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20407
> https://issues.apache.org/jira/browse/AMBARI-20407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57543/diff/1/
>
>
> Testing
> -------
>
> Ran unit tests locally
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.014s]
> [INFO] utility ........................................... SUCCESS [1.311s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 57543: When agent retries commands it needs to
handle credential store processing correctly
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57543/#review168814
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py
Line 373 (original), 373-377 (patched)
<https://reviews.apache.org/r/57543/#comment241065>
Probably it will be good for Robert Levas to take a look at these changes.
- Vitalyi Brodetskyi
On \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 12, 2017, 8:12 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57543/
> -----------------------------------------------------------
>
> (Updated \u0411\u0435\u0440\u0435\u0437\u0435\u043d\u044c 12, 2017, 8:12 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
>
>
> Review request for Ambari, Madhuvanthi Radhakrishnan, Swapan Shridhar, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20407
> https://issues.apache.org/jira/browse/AMBARI-20407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When agent retries commands it needs to handle credential store processing correctly (see bug for more details)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ActionQueue.py 15ae03d
> ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py ee34685
> ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 8701a24
>
>
> Diff: https://reviews.apache.org/r/57543/diff/1/
>
>
> Testing
> -------
>
> Ran unit tests locally
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [4.014s]
> [INFO] utility ........................................... SUCCESS [1.311s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [8.301s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:36.871s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
>
> Thanks,
>
> Sumit Mohanty
>
>