You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 00:42:37 UTC
[GitHub] [incubator-superset] nruhe opened a new pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
nruhe opened a new pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
The SPA menu component was relying on a hardcoded icon width of 126. This change exposes the config.py APP_ICON_WIDTH property to the frontend through the apps bootstrapping process and alters the SPA menu component to consume this value as the logo image width.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
### TEST PLAN
Set APP_ICON_WIDTH property to a value other than 126 and observe the SPA and template version of the header have matching logo sizes.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [X] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=h1) Report
> Merging [#9666](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.33%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 64.03% 70.36% +6.33%
==========================================
Files 532 182 -350
Lines 28897 17755 -11142
Branches 2758 0 -2758
==========================================
- Hits 18503 12494 -6009
+ Misses 10211 5261 -4950
+ Partials 183 0 -183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.36% <ø> (-0.20%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <ø> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.81% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| ... and [353 more](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=footer). Last update [5e4c291...8d81db3](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=h1) Report
> Merging [#9666](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 64.03% 70.58% +6.55%
==========================================
Files 532 182 -350
Lines 28897 17755 -11142
Branches 2758 0 -2758
==========================================
- Hits 18503 12533 -5970
+ Misses 10211 5222 -4989
+ Partials 183 0 -183
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `70.58% <ø> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | | |
| [...d/src/dashboard/components/InsertComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0luc2VydENvbXBvbmVudFBhbmUuanN4) | | |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | | |
| [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | | |
| [.../src/explore/components/controls/SliderControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLmpzeA==) | | |
| [...t-frontend/src/explore/controlPanels/Partition.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9QYXJ0aXRpb24uanN4) | | |
| ... and [345 more](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=footer). Last update [5e4c291...8d81db3](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620389819
> could you set the width in the config file to 126? Then we'll both have documentation of the config var existing, and can replace the `config.get` with a `config["APP_ICON_WIDTH"]` because we can always assume it exists
It appears `APP_ICON_WIDTH` is [already set to 126](https://github.com/apache/incubator-superset/blob/c474ea848a1c5e611d1b30301686aa83eb2cda06/superset/config.py#L183) in `config.py`.
There are a handful of other config.get instances that pull in existing vars from `config.py` - I'm not sure how big an issue is, or if it should be blocking for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620389819
> could you set the width in the config file to 126? Then we'll both have documentation of the config var existing, and can replace the `config.get` with a `config["APP_ICON_WIDTH"]` because we can always assume it exists
It appears `APP_ICON_WIDTH` is [already set to 126](https://github.com/apache/incubator-superset/blob/c474ea848a1c5e611d1b30301686aa83eb2cda06/superset/config.py#L183) in `config.py`.
There are a handful of other config.get instances that pull in existing vars from `config.py` - I'm not sure how big an issue one more is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=h1) Report
> Merging [#9666](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `1.67%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 64.03% 65.70% +1.67%
==========================================
Files 532 581 +49
Lines 28897 30216 +1319
Branches 2758 3072 +314
==========================================
+ Hits 18503 19854 +1351
+ Misses 10211 10181 -30
+ Partials 183 181 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.75% <ø> (?)` | |
| #python | `70.58% <ø> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [272 more](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=footer). Last update [5e4c291...8d81db3](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=h1) Report
> Merging [#9666](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.49%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 64.03% 70.52% +6.49%
==========================================
Files 532 581 +49
Lines 28897 30216 +1319
Branches 2758 3072 +314
==========================================
+ Hits 18503 21311 +2808
+ Misses 10211 8793 -1418
+ Partials 183 112 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.62% <ø> (-0.04%)` | :arrow_down: |
| #javascript | `58.75% <ø> (?)` | |
| #python | `70.62% <ø> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <ø> (ø)` | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | `100.00% <0.00%> (ø)` | |
| [...rset-frontend/src/components/StackTraceMessage.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3RhY2tUcmFjZU1lc3NhZ2UuanN4) | | |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=footer). Last update [5e4c291...8d81db3](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620667034
We've tried to standardize around `config[]` over `config.get` in the past, so I think it's better to keep going in that direction. see https://github.com/apache/incubator-superset/pull/8454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9666: [fix] Support APP_ICON_WIDTH configuration parameter in SPA menu
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9666:
URL: https://github.com/apache/incubator-superset/pull/9666#issuecomment-620311287
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=h1) Report
> Merging [#9666](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5e4c2919135e284c50a4bdeb1ecff54514804a6b&el=desc) will **increase** coverage by `6.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 64.03% 70.32% +6.29%
==========================================
Files 532 581 +49
Lines 28897 30216 +1319
Branches 2758 3072 +314
==========================================
+ Hits 18503 21249 +2746
+ Misses 10211 8849 -1362
+ Partials 183 118 -65
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.82% <ø> (-0.84%)` | :arrow_down: |
| #javascript | `58.75% <ø> (?)` | |
| #python | `70.62% <ø> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <ø> (ø)` | |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `7.27% <0.00%> (-92.73%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (-2.79%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-2.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (-1.10%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/SqlLab/utils/sqlKeywords.ts](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9zcWxLZXl3b3Jkcy50cw==) | `100.00% <0.00%> (ø)` | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/9666/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=footer). Last update [5e4c291...8d81db3](https://codecov.io/gh/apache/incubator-superset/pull/9666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org