You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "siddhantsangwan (via GitHub)" <gi...@apache.org> on 2023/01/24 17:59:37 UTC
[GitHub] [ozone] siddhantsangwan opened a new pull request, #4204: HDDS-7818. Modify Ratis Replication Handling in the new RM
siddhantsangwan opened a new pull request, #4204:
URL: https://github.com/apache/ozone/pull/4204
## What changes were proposed in this pull request?
This Jira is to modify the under and over replication handling to fit with the new changes introduced in [HDDS-7804](https://issues.apache.org/jira/browse/HDDS-7804) and [HDDS-7813](https://issues.apache.org/jira/browse/HDDS-7813). The respective handlers should deal with replicas that are not UNHEALTHY.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7818
## How was this patch tested?
Added unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #4204: HDDS-7818. Modify Ratis Replication Handling in the new RM
Posted by "siddhantsangwan (via GitHub)" <gi...@apache.org>.
siddhantsangwan commented on code in PR #4204:
URL: https://github.com/apache/ozone/pull/4204#discussion_r1086484635
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestRatisReplicationCheckHandler.java:
##########
@@ -294,6 +296,80 @@ public void testUnderReplicatedAndUnrecoverable() {
ReplicationManagerReport.HealthState.MISSING));
}
+ /**
+ * Replicas with ContainerReplicaProto#State UNHEALTHY don't contribute to
+ * the redundancy of a container. This tests that a CLOSED container with {
+ * CLOSED, CLOSED, UNHEALTHY, UNHEALTHY} replicas is under replicated.
+ */
+ @Test
+ public void testUnderReplicatedWithUnhealthyReplicas() {
+ ContainerInfo container = createContainerInfo(repConfig);
+ Set<ContainerReplica> replicas
+ = createReplicas(container.containerID(), State.CLOSED, 0, 0);
+ Set<ContainerReplica> unhealthyReplicas =
+ createReplicas(container.containerID(), State.UNHEALTHY, 0, 0);
+ replicas.addAll(unhealthyReplicas);
+ requestBuilder.setContainerReplicas(replicas)
+ .setContainerInfo(container);
+ UnderReplicatedHealthResult result = (UnderReplicatedHealthResult)
+ healthCheck.checkHealth(requestBuilder.build());
+
+ Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState());
+ Assert.assertEquals(1, result.getRemainingRedundancy());
+ Assert.assertFalse(result.isReplicatedOkAfterPending());
+ Assert.assertFalse(result.underReplicatedDueToDecommission());
+
+ Assert.assertTrue(healthCheck.handle(requestBuilder.build()));
+ Assert.assertEquals(1, repQueue.underReplicatedQueueSize());
+ Assert.assertEquals(0, repQueue.overReplicatedQueueSize());
+ Assert.assertEquals(1, report.getStat(
+ ReplicationManagerReport.HealthState.UNDER_REPLICATED));
+ }
+
+ @Test
+ public void testSufficientReplicationWithMismatchedReplicas() {
+ ContainerInfo container = createContainerInfo(repConfig);
+ Set<ContainerReplica> replicas
+ = createReplicas(container.containerID(), State.CLOSING, 0, 0, 0);
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a diff in pull request #4204: HDDS-7818. Modify Ratis Replication Handling in the new RM
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #4204:
URL: https://github.com/apache/ozone/pull/4204#discussion_r1086446542
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestRatisReplicationCheckHandler.java:
##########
@@ -294,6 +296,80 @@ public void testUnderReplicatedAndUnrecoverable() {
ReplicationManagerReport.HealthState.MISSING));
}
+ /**
+ * Replicas with ContainerReplicaProto#State UNHEALTHY don't contribute to
+ * the redundancy of a container. This tests that a CLOSED container with {
+ * CLOSED, CLOSED, UNHEALTHY, UNHEALTHY} replicas is under replicated.
+ */
+ @Test
+ public void testUnderReplicatedWithUnhealthyReplicas() {
+ ContainerInfo container = createContainerInfo(repConfig);
+ Set<ContainerReplica> replicas
+ = createReplicas(container.containerID(), State.CLOSED, 0, 0);
+ Set<ContainerReplica> unhealthyReplicas =
+ createReplicas(container.containerID(), State.UNHEALTHY, 0, 0);
+ replicas.addAll(unhealthyReplicas);
+ requestBuilder.setContainerReplicas(replicas)
+ .setContainerInfo(container);
+ UnderReplicatedHealthResult result = (UnderReplicatedHealthResult)
+ healthCheck.checkHealth(requestBuilder.build());
+
+ Assert.assertEquals(HealthState.UNDER_REPLICATED, result.getHealthState());
+ Assert.assertEquals(1, result.getRemainingRedundancy());
+ Assert.assertFalse(result.isReplicatedOkAfterPending());
+ Assert.assertFalse(result.underReplicatedDueToDecommission());
+
+ Assert.assertTrue(healthCheck.handle(requestBuilder.build()));
+ Assert.assertEquals(1, repQueue.underReplicatedQueueSize());
+ Assert.assertEquals(0, repQueue.overReplicatedQueueSize());
+ Assert.assertEquals(1, report.getStat(
+ ReplicationManagerReport.HealthState.UNDER_REPLICATED));
+ }
+
+ @Test
+ public void testSufficientReplicationWithMismatchedReplicas() {
+ ContainerInfo container = createContainerInfo(repConfig);
+ Set<ContainerReplica> replicas
+ = createReplicas(container.containerID(), State.CLOSING, 0, 0, 0);
Review Comment:
Are these mis-matches as the container is CLOSED, but the replicas are CLOSING?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #4204: HDDS-7818. Modify Ratis Replication Handling in the new RM
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #4204:
URL: https://github.com/apache/ozone/pull/4204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org