You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stormcrawler.apache.org by "chhsiao90 (via GitHub)" <gi...@apache.org> on 2024/07/05 01:01:45 UTC
[I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
chhsiao90 opened a new issue, #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246
What kind of issue is this?
- [ ] Question. This issue tracker is not the best place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use StackOverflow
instead with the label 'stormcrawler': https://stackoverflow.com/questions/tagged/stormcrawler
- [ ] Bug report. If you’ve found a bug, please include a test if you can, it makes it a lot easier to fix things. Use the label 'bug' on the issue.
- [x] Feature request. Please use the label 'wish' on the issue.
In our use case, we have our own ProxyManager implementation, we'd like to have the flexibility to use proxies for some requests, but no proxy for other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
Posted by "chhsiao90 (via GitHub)" <gi...@apache.org>.
chhsiao90 commented on issue #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246#issuecomment-2209736431
I'd like to create a PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
Posted by "quangdutran (via GitHub)" <gi...@apache.org>.
quangdutran commented on issue #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246#issuecomment-2869629754
Thank you, please review my change once you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
Posted by "jnioche (via GitHub)" <gi...@apache.org>.
jnioche commented on issue #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246#issuecomment-2210396039
Yes please.
[ProxyManager](https://github.com/apache/incubator-stormcrawler/blob/dc84c569bc4fd94d3935a63478c00c8f3bfcbaca/core/src/main/java/org/apache/stormcrawler/proxy/ProxyManager.java#L29) could return an Optional<SCProxy> depending on the Metadata. The code in the protocol implementations would need changing accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
Posted by "quangdutran (via GitHub)" <gi...@apache.org>.
quangdutran commented on issue #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246#issuecomment-2869547362
@rzo1 Maybe I could help with this as following @jnioche suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [incubator-stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on issue #1246:
URL: https://github.com/apache/incubator-stormcrawler/issues/1246#issuecomment-2869606508
Feel free. We welcome every external contribution. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests [stormcrawler]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 closed issue #1246: To allow ProxyManager return null (or empty proxy) for not using a proxy for some specific requests
URL: https://github.com/apache/stormcrawler/issues/1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@stormcrawler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org