You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:16:52 UTC

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #14: Owning/mutable `struct ArrowArray`

paleolimbot commented on code in PR #14:
URL: https://github.com/apache/arrow-nanoarrow/pull/14#discussion_r940170048


##########
src/nanoarrow/typedefs_inline.h:
##########
@@ -165,6 +212,20 @@ struct ArrowBitmap {
   int64_t size_bits;
 };
 
+/// \brief A structure used as the private data member for ArrowArrays allocated here

Review Comment:
   The definition needs to be visible for the appenders to be inlined (I removed the documentation comments and gave it a scarier name of `ArrowArrayPrivateData` to hopefully make that clearer).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org