You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Christopher L. Shannon (JIRA)" <ji...@apache.org> on 2015/10/01 19:04:26 UTC
[jira] [Assigned] (AMQ-5990) PooledConnectionFactory does not allow
disabling JMX on GenericKeyObjectPool
[ https://issues.apache.org/jira/browse/AMQ-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christopher L. Shannon reassigned AMQ-5990:
-------------------------------------------
Assignee: Christopher L. Shannon
This seems fine to me, I can apply the patch with a couple of tweaks.
> PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool
> ----------------------------------------------------------------------------
>
> Key: AMQ-5990
> URL: https://issues.apache.org/jira/browse/AMQ-5990
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Aravind Chennuru
> Assignee: Christopher L. Shannon
> Fix For: 5.12.1
>
> Attachments: patchfile.txt
>
>
> initConnectionPool does not allow us to configure the GenericKeyObjectPool.
> Suggestion:
> PooledConnectionFactory
> {code}
> private GenericKeyedObjectPoolConfig config;
> public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
> this.config = config;
> }
> public void initConnectionsPool() {
> if (this.connectionsPool == null) {
> this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
> }
> }
> protected ConnectionPool createConnectionPool(Connection connection) {
> return new ConnectionPool(connection, config);
> }
> {code}
> ConnectionPool
> {code}
> public ConnectionPool(Connection connection) {
> this(connection, new GenericKeyedObjectPoolConfig());
> }
> public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig config) {
> this.connection = wrap(connection);
> this.sessionPool = new GenericKeyedObjectPool<SessionKey, SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)