You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:06:15 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
michael-s-molina opened a new pull request #12447:
URL: https://github.com/apache/superset/pull/12447
### SUMMARY
Apply capitalization guidelines defined in #12343.
@junlincc
### TEST PLAN
Check if modified texts are following capitalization guidelines.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758697286
# [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=h1) Report
> Merging [#12447](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=desc) (e25d043) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.58%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 62.22% -4.59%
==========================================
Files 1015 1015
Lines 49544 49515 -29
Branches 5080 5080
==========================================
- Hits 33102 30811 -2291
- Misses 16312 18495 +2183
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <20.00%> (ø)` | |
| python | `63.18% <ø> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.25% <ø> (-26.91%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `83.33% <ø> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `16.00% <ø> (-44.00%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.09% <0.00%> (-66.37%)` | :arrow_down: |
| [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [234 more](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=footer). Last update [078a8a1...e25d043](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc removed a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc removed a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758725962
@steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758865629
@ktmud We could have some problems with translation. I'm currently working on server side texts and translation generation. The idea here is to hold after 1.0.0 so we can merge all capitalization PRs and execute a throughout test with translation capabilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758863174
Oops, forgot we are holding merges for v1.0.0 and this is marked as v1.0.1... But I guess there is not harm shipping this earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758870489
@ktmud But don't worry about this merged iteration. Currently translations are disabled by default and are incomplete anyway 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758725962
please specify all your changes in this PR, include screenshot and test plan. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758929957
😉 @michael-s-molina the changes you made in those iteration is significant to Superset, we can't wait to see all of them to get in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758697286
# [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=h1) Report
> Merging [#12447](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=desc) (e25d043) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `6.05%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 60.75% -6.06%
==========================================
Files 1015 529 -486
Lines 49544 19616 -29928
Branches 5080 5080
==========================================
- Hits 33102 11918 -21184
+ Misses 16312 7489 -8823
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <20.00%> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.25% <ø> (-26.91%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `83.33% <ø> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `16.00% <ø> (-44.00%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.09% <0.00%> (-66.37%)` | :arrow_down: |
| [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [684 more](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=footer). Last update [078a8a1...e25d043](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758697286
# [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=h1) Report
> Merging [#12447](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=desc) (e25d043) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.39%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 62.41% -4.40%
==========================================
Files 1015 1015
Lines 49544 49515 -29
Branches 5080 5080
==========================================
- Hits 33102 30906 -2196
- Misses 16312 18400 +2088
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <20.00%> (ø)` | |
| python | `63.50% <ø> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.25% <ø> (-26.91%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `83.33% <ø> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `16.00% <ø> (-44.00%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.09% <0.00%> (-66.37%)` | :arrow_down: |
| [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [220 more](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=footer). Last update [078a8a1...e25d043](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758839353
looks good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758725962
@steejay @mihir174 since Design will review this PR, to make it easier for them, please give a list of menu items that has changed in the description. @michael-s-molina
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758697286
# [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=h1) Report
> Merging [#12447](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=desc) (e25d043) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.36%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 62.44% -4.37%
==========================================
Files 1015 1015
Lines 49544 49515 -29
Branches 5080 5080
==========================================
- Hits 33102 30922 -2180
- Misses 16312 18384 +2072
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <20.00%> (ø)` | |
| python | `63.56% <ø> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.25% <ø> (-26.91%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `83.33% <ø> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `16.00% <ø> (-44.00%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.09% <0.00%> (-66.37%)` | :arrow_down: |
| [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [218 more](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=footer). Last update [078a8a1...e25d043](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12447:
URL: https://github.com/apache/superset/pull/12447#issuecomment-758697286
# [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=h1) Report
> Merging [#12447](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=desc) (e25d043) into [master](https://codecov.io/gh/apache/superset/commit/078a8a17a1883ace050bc3baa0bd500e300e61b1?el=desc) (078a8a1) will **decrease** coverage by `4.36%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12447 +/- ##
==========================================
- Coverage 66.81% 62.44% -4.37%
==========================================
Files 1015 1015
Lines 49544 49530 -14
Branches 5080 5080
==========================================
- Hits 33102 30929 -2173
- Misses 16312 18392 +2080
- Partials 130 209 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.75% <20.00%> (ø)` | |
| python | `63.55% <ø> (-0.53%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.25% <ø> (-26.91%)` | :arrow_down: |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | `83.33% <ø> (-12.50%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `16.00% <ø> (-44.00%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.09% <0.00%> (-66.37%)` | :arrow_down: |
| [...components/controls/DateFilterControl/constants.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [...ore/components/controls/DateFilterControl/types.ts](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `26.82% <ø> (ø)` | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `72.22% <100.00%> (-2.78%)` | :arrow_down: |
| ... and [210 more](https://codecov.io/gh/apache/superset/pull/12447/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=footer). Last update [078a8a1...e25d043](https://codecov.io/gh/apache/superset/pull/12447?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12447: chore: apply capitalization guidelines - iteration 1 (#12343)
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12447:
URL: https://github.com/apache/superset/pull/12447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org