You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2018/11/21 15:00:33 UTC

[GitHub] spark pull request #23105: [SPARK-26140] Enable passing in a custom shuffle ...

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23105#discussion_r235420647
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/ShuffleReadMetrics.scala ---
    @@ -122,34 +123,3 @@ class ShuffleReadMetrics private[spark] () extends Serializable {
         }
       }
     }
    -
    -/**
    - * A temporary shuffle read metrics holder that is used to collect shuffle read metrics for each
    - * shuffle dependency, and all temporary metrics will be merged into the [[ShuffleReadMetrics]] at
    - * last.
    - */
    -private[spark] class TempShuffleReadMetrics {
    --- End diff --
    
    this was moved to TempShuffleReadMetrics


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org