You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/20 17:33:09 UTC

[GitHub] [geode] mhansonp commented on a diff in pull request #7554: GEM-3124: Guarding membership addition code paths to omit membership …

mhansonp commented on code in PR #7554:
URL: https://github.com/apache/geode/pull/7554#discussion_r854389384


##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -2345,7 +2368,9 @@ public void newMemberConnected(InternalDistributedMember member) {
       // subsequent deadlock (#45566). Elder selection is now done when a view
       // is installed.
       try {
+        // if (!dm.getViewMembers().contains(member)) {

Review Comment:
   probably should remove this test code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org