You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Mandar Ambawane <ma...@freestoneinfotech.com> on 2020/03/25 19:40:04 UTC
Review Request 72270: ATLAS-3689 Add audits entries when Business
Metadata Attributes are added/updated/deleted to an entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689
Repository: atlas
Description
-------
Add audits entries when Namespace Attributes are added/updated/deleted to an entity
Diffs
-----
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 75b016c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec
Diff: https://reviews.apache.org/r/72270/diff/1/
Testing
-------
Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
Basic testing is done.
Thanks,
Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business
Metadata Attributes are added/updated/deleted to an entity
Posted by Mandar Ambawane <ma...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
-----------------------------------------------------------
(Updated March 31, 2020, 7:28 a.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Addressed review comments
Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689
Repository: atlas
Description
-------
Add audits entries when Namespace Attributes are added/updated/deleted to an entity
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12
intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 75b016c
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec
Diff: https://reviews.apache.org/r/72270/diff/2/
Changes: https://reviews.apache.org/r/72270/diff/1-2/
Testing
-------
Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
Basic testing is done.
Thanks,
Mandar Ambawane
Re: Review Request 72270: ATLAS-3689 Add audits entries when Business
Metadata Attributes are added/updated/deleted to an entity
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220098
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Line 53 (original), 54 (patched)
<https://reviews.apache.org/r/72270/#comment308403>
Avoid import *
- Nixon Rodrigues
On March 25, 2020, 7:40 p.m., Mandar Ambawane wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> -----------------------------------------------------------
>
> (Updated March 25, 2020, 7:40 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Add audits entries when Namespace Attributes are added/updated/deleted to an entity
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 2394a12
> intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 9301e21
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java 590f7a0
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java cab4e1e
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 00c0114
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 75b016c
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java c4dc5a1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java 2943ea9
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 6d64fec
>
>
> Diff: https://reviews.apache.org/r/72270/diff/1/
>
>
> Testing
> -------
>
> Pre-commit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
>
> Basic testing is done.
>
>
> Thanks,
>
> Mandar Ambawane
>
>