[jira] [Commented] (PROTON-1819) [cpp] handle running out of sessions properly

["Andrew Stitcher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426267#comment-16426267 ] 

Andrew Stitcher commented on PROTON-1819:
-----------------------------------------

Note that I believe (based on my comments to PROTON-1759) that throwing an exception instead of returning NULL may not help much because I don't think that null is actually returned from pn_session() etc. anyway. The failure is later when the protocol engine tries to actually create the protocol session and then can't because the max number of sessions has been exceeded.

> [cpp] handle running out of sessions properly
> ---------------------------------------------
>
>                 Key: PROTON-1819
>                 URL: https://issues.apache.org/jira/browse/PROTON-1819
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: proton-c-0.22.0
>            Reporter: Alan Conway
>            Priority: Major
>             Fix For: proton-c-0.23.0
>
>
> C++ binding does not handle running out of sessions correctly, see:
> [https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/cpp/src/connection.cpp#L113]
>  
> The binding should throw an exception rather than returning a null session, which will almost certainly cause a core dump when the application tries to use it.
> This issue was pointed out by the reporter of
> https://bugzilla.redhat.com/show_bug.cgi?id=1561876



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org