[GitHub] [spark] imback82 opened a new pull request #26894: [SPARK-30094][SQL] Apply current namespace for the single-part table name

[GitBox <gi...@apache.org>]

imback82 opened a new pull request #26894: [SPARK-30094][SQL] Apply current namespace for the single-part table name
URL: https://github.com/apache/spark/pull/26894
 
 
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This PR applies the current namespace for the single-part table name if the current catalog is a non-session catalog.
   
   Note that the reason the current namespace is not applied for the session catalog is that the single-part name could be referencing a temp view which doesn't belong to any namespaces. The empty namespace for a table inside the session catalog is resolved by the session catalog implementation.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   It's fixing the following bug where the current namespace is not respected:
   ```
   sql("CREATE TABLE testcat.ns.t USING foo AS SELECT 1 AS id")
   sql("USE testcat.ns")
   sql("SHOW CURRENT NAMESPACE").show
   +-------+---------+
   |catalog|namespace|
   +-------+---------+
   |testcat|       ns|
   +-------+---------+
   
   // `t` is not resolved since the current namespace `ns` is not used.
   sql("DESCRIBE t").show
   Failed to analyze query: org.apache.spark.sql.AnalysisException: Table not found: t;;
   ```
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   Yes, the above `DESCRIBE` command will succeed.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org