You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/12/18 00:58:12 UTC

[jira] [Commented] (HBASE-7370) Remove Writable From ScanMetrics.

    [ https://issues.apache.org/jira/browse/HBASE-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534441#comment-13534441 ] 

stack commented on HBASE-7370:
------------------------------

In hbase.proto we have NameStringPair and NameBytesPair... You add NameInt64Pair here in your MR.proto.... Should it be back in hbase.proto?  (No biggie).

+1 on patch (Elliott said he'd add comments on why new preference for AtomicLong over MetricsTimeVaryingLong....)
                
> Remove Writable From ScanMetrics.
> ---------------------------------
>
>                 Key: HBASE-7370
>                 URL: https://issues.apache.org/jira/browse/HBASE-7370
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce, metrics
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>         Attachments: HBASE-7370-0.patch
>
>
> Right now ScanMetrics uses Writable to be able to set MapReduce counters.  We should remove this and use protobuf.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira