You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Robert Houghton <rh...@apache.org> on 2020/10/30 20:52:15 UTC
Utilizing GitHub .CODEOWNERS files
Thanks to @udo and @nabarunnag the conversations and ideas around having
better review processes and review quality.
TL;DR - Adding GitHub CODEOWNERS[1] to geode-examples, eye toward adding to
GEODE
GitHub provides a mechanism of assigning code ownership to specific
owners/committers based on file pattern-matching (similar to .gitignore).
Owners are automatically added as reviewers to pull-requests against their
described areas. This, coupled with our review requirements[2], could
really help us get the right eyes on prospective code changes.
I intend to add this file to the apache/geode-examples repository, tagging
myself and a few volunteers to different code areas, and checking the
results. If we like it, we can move on to doing the same to Geode.
Will anyone volunteer to get code-reviews for geode-examples changes (that
we won't merge) ?
Thanks,
-Robert Houghton
[1]
https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners
[2]
https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features#git.asf.yamlfeatures-BranchProtection
Re: Utilizing GitHub .CODEOWNERS files
Posted by Dave Barnes <db...@apache.org>.
If 'docs' can be identified as a separate code area, then add my name to
the experimental owners' list.
On Fri, Oct 30, 2020 at 2:11 PM Owen Nichols <on...@vmware.com> wrote:
> I'd be happy to volunteer as well
>
> On 10/30/20, 2:10 PM, "Dan Smith" <da...@vmware.com> wrote:
>
> Hi Robert,
>
> Seems like a reasonable experiment. You can tag me if you like.
>
> Thanks,
> -Dan
> ________________________________
> From: Robert Houghton <rh...@apache.org>
> Sent: Friday, October 30, 2020 1:52 PM
> To: dev@geode.apache.org <de...@geode.apache.org>
> Subject: Utilizing GitHub .CODEOWNERS files
>
> Thanks to @udo and @nabarunnag the conversations and ideas around
> having
> better review processes and review quality.
>
> TL;DR - Adding GitHub CODEOWNERS[1] to geode-examples, eye toward
> adding to
> GEODE
>
> GitHub provides a mechanism of assigning code ownership to specific
> owners/committers based on file pattern-matching (similar to
> .gitignore).
> Owners are automatically added as reviewers to pull-requests against
> their
> described areas. This, coupled with our review requirements[2], could
> really help us get the right eyes on prospective code changes.
>
> I intend to add this file to the apache/geode-examples repository,
> tagging
> myself and a few volunteers to different code areas, and checking the
> results. If we like it, we can move on to doing the same to Geode.
>
> Will anyone volunteer to get code-reviews for geode-examples changes
> (that
> we won't merge) ?
>
> Thanks,
> -Robert Houghton
>
> [1]
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Ffree-pro-team%40latest%2Fgithub%2Fcreating-cloning-and-archiving-repositories%2Fabout-code-owners&data=04%7C01%7Conichols%40vmware.com%7C1404a0b2a4c54645dd4608d87d182e51%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396890095569226%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Xtca2KkWOtMJCm0DVcBPyNlJUSB8STXe8BLoIOCSGao%3D&reserved=0
> [2]
>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FINFRA%2Fgit%2B-%2B.asf.yaml%2Bfeatures%23git.asf.yamlfeatures-BranchProtection&data=04%7C01%7Conichols%40vmware.com%7C1404a0b2a4c54645dd4608d87d182e51%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396890095569226%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZF%2BC96kpEVwpG15RwLgYvlhdhMenI8y7LzoYumN9YJo%3D&reserved=0
>
>
Re: Utilizing GitHub .CODEOWNERS files
Posted by Owen Nichols <on...@vmware.com>.
I'd be happy to volunteer as well
On 10/30/20, 2:10 PM, "Dan Smith" <da...@vmware.com> wrote:
Hi Robert,
Seems like a reasonable experiment. You can tag me if you like.
Thanks,
-Dan
________________________________
From: Robert Houghton <rh...@apache.org>
Sent: Friday, October 30, 2020 1:52 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Utilizing GitHub .CODEOWNERS files
Thanks to @udo and @nabarunnag the conversations and ideas around having
better review processes and review quality.
TL;DR - Adding GitHub CODEOWNERS[1] to geode-examples, eye toward adding to
GEODE
GitHub provides a mechanism of assigning code ownership to specific
owners/committers based on file pattern-matching (similar to .gitignore).
Owners are automatically added as reviewers to pull-requests against their
described areas. This, coupled with our review requirements[2], could
really help us get the right eyes on prospective code changes.
I intend to add this file to the apache/geode-examples repository, tagging
myself and a few volunteers to different code areas, and checking the
results. If we like it, we can move on to doing the same to Geode.
Will anyone volunteer to get code-reviews for geode-examples changes (that
we won't merge) ?
Thanks,
-Robert Houghton
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Ffree-pro-team%40latest%2Fgithub%2Fcreating-cloning-and-archiving-repositories%2Fabout-code-owners&data=04%7C01%7Conichols%40vmware.com%7C1404a0b2a4c54645dd4608d87d182e51%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396890095569226%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Xtca2KkWOtMJCm0DVcBPyNlJUSB8STXe8BLoIOCSGao%3D&reserved=0
[2]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FINFRA%2Fgit%2B-%2B.asf.yaml%2Bfeatures%23git.asf.yamlfeatures-BranchProtection&data=04%7C01%7Conichols%40vmware.com%7C1404a0b2a4c54645dd4608d87d182e51%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396890095569226%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZF%2BC96kpEVwpG15RwLgYvlhdhMenI8y7LzoYumN9YJo%3D&reserved=0
Re: Utilizing GitHub .CODEOWNERS files
Posted by Dan Smith <da...@vmware.com>.
Hi Robert,
Seems like a reasonable experiment. You can tag me if you like.
Thanks,
-Dan
________________________________
From: Robert Houghton <rh...@apache.org>
Sent: Friday, October 30, 2020 1:52 PM
To: dev@geode.apache.org <de...@geode.apache.org>
Subject: Utilizing GitHub .CODEOWNERS files
Thanks to @udo and @nabarunnag the conversations and ideas around having
better review processes and review quality.
TL;DR - Adding GitHub CODEOWNERS[1] to geode-examples, eye toward adding to
GEODE
GitHub provides a mechanism of assigning code ownership to specific
owners/committers based on file pattern-matching (similar to .gitignore).
Owners are automatically added as reviewers to pull-requests against their
described areas. This, coupled with our review requirements[2], could
really help us get the right eyes on prospective code changes.
I intend to add this file to the apache/geode-examples repository, tagging
myself and a few volunteers to different code areas, and checking the
results. If we like it, we can move on to doing the same to Geode.
Will anyone volunteer to get code-reviews for geode-examples changes (that
we won't merge) ?
Thanks,
-Robert Houghton
[1]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.github.com%2Fen%2Ffree-pro-team%40latest%2Fgithub%2Fcreating-cloning-and-archiving-repositories%2Fabout-code-owners&data=04%7C01%7Cdasmith%40vmware.com%7C273687aed5ef4495269d08d87d15b861%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396879528034900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=KRlme5Dyll%2FkoObolhrNQG%2BVw%2Ft02TQs20LqqvlUKRs%3D&reserved=0
[2]
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FINFRA%2Fgit%2B-%2B.asf.yaml%2Bfeatures%23git.asf.yamlfeatures-BranchProtection&data=04%7C01%7Cdasmith%40vmware.com%7C273687aed5ef4495269d08d87d15b861%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637396879528034900%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vVbnergXVXdPCOw9D8tMOFTqaiaepLFa%2BtojjHcQrzc%3D&reserved=0