You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/18 12:06:06 UTC
[GitHub] [incubator-doris] ccoffline opened a new pull request #4921: fix partition prune (#4833)
ccoffline opened a new pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921
## Proposed changes
According to @morningman in #4836
> We should check if inPredicate.getChild(0) is not a slotRef, do not create partition filter for it.
> So it won't goes to the compareLiteral() logic.
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #4921: [Bug] Fix partition prune (#4833)
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921#issuecomment-729636157
I still don't understand the concept of `SlotRef`=.=
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline edited a comment on pull request #4921: [Bug] Fix partition prune (#4833)
Posted by GitBox <gi...@apache.org>.
ccoffline edited a comment on pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921#issuecomment-731901589
> SlotRef sometimes means a "Column"
thx~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] ccoffline commented on pull request #4921: [Bug] Fix partition prune (#4833)
Posted by GitBox <gi...@apache.org>.
ccoffline commented on pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921#issuecomment-731901589
> SlotRef sometimes means a "Column"
thx~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4921: [Bug] Fix partition prune (#4833)
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4921: [Bug] Fix partition prune (#4833)
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4921:
URL: https://github.com/apache/incubator-doris/pull/4921#issuecomment-731578429
> I still don't understand the concept of `SlotRef`=.=
SlotRef sometimes means a "Column"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org