You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 15:04:57 UTC
[GitHub] [beam] mosche opened a new pull request, #22473: WIP: Support TestStream for Spark runner in streaming mode (#22472).
mosche opened a new pull request, #22473:
URL: https://github.com/apache/beam/pull/22473
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche closed pull request #22473: WIP: Support TestStream for Spark runner in streaming mode (#22472).
Posted by GitBox <gi...@apache.org>.
mosche closed pull request #22473: WIP: Support TestStream for Spark runner in streaming mode (#22472).
URL: https://github.com/apache/beam/pull/22473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #22473: WIP: Support TestStream for Spark runner in streaming mode (#22472).
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #22473:
URL: https://github.com/apache/beam/pull/22473#discussion_r931186776
##########
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java:
##########
@@ -453,7 +454,9 @@ TransformEvaluator<TransformT> translate(
} else {
pValues = node.getInputs();
}
- PCollection.IsBounded isNodeBounded = isBoundedCollection(pValues.values());
+ // FIXME Why is the output of TestSparkRunner.UnboundedReadFromBoundedSourceOverrideFactory BOUNDED!?!
Review Comment:
@aromanenko-dev @echauchot A bit stuck here.... Wondering if you have any idea what the issue is, see the replacement below. It replaces a bounded read with an unbounded read so validates runner tests using `Create.of(...)` can be run in streaming mode.
However, `isBounded` of the output still returns `BOUNDED` 🤯
https://github.com/apache/beam/pull/22473/files#diff-d81f49eb0330230bd03ce6cd33b5f70f59c443aac57741e877ececbada32b16bR112-R117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org