You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2017/01/28 09:56:51 UTC
[GitHub] thrift pull request #1166: THRIFT-4026 TSSLSocket doesn't work with Python <...
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/1166
THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-4026
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1166
----
commit a348099d80a331a81e7f224cf8299933517e9895
Author: Nobuaki Sukegawa <ns...@gmail.com>
Date: 2017-01-28T09:53:01Z
THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1166: THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9
Posted by tsuna <gi...@git.apache.org>.
Github user tsuna commented on the issue:
https://github.com/apache/thrift/pull/1166
LGTM, thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1166: THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1166
I fixed the build job #17 issue with THRIFT-4044 so you can merge this or rebase to get a clean build first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1166: THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1166
Build job 17 has been failing due to a haskell issue fairly regularly. I don't know how to fix it, but if we can clear it out it would be nice. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1166: THRIFT-4026 TSSLSocket doesn't work with Python <...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1166#discussion_r98337162
--- Diff: build/docker/centos6/Dockerfile ---
@@ -41,7 +41,9 @@ RUN yum install -y epel-release && \
&& yum clean all
# optional dependencies
-RUN pip install ipaddress backports.ssl_match_hostname tornado
+# skipping ipaddress and backports.ssl_match_hostname to test legacy callback
+# RUN pip install ipaddress backports.ssl_match_hostname tornado
+RUN pip install tornado
--- End diff --
Does the ubuntu docker build need to be modified to match?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1166: THRIFT-4026 TSSLSocket doesn't work with Python <...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---