You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/02/02 07:39:03 UTC

Re: Review Request 43007: Implement Activate HAWQ Standby wizard to allow doing failover in HA mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43007/#review117368
-----------------------------------------------------------


Ship it!




Ship It!

- Matt


On Jan. 29, 2016, 6:44 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43007/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 6:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, and Richard Zang.
> 
> 
> Bugs: AMBARI-14820
>     https://issues.apache.org/jira/browse/AMBARI-14820
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> #Activate HAWQ Standby Wizard
> Abstract:
> All configuration changes done on Ambari managed clusters must be done via Ambari, otherwise during restart of services, Ambari pushes the configuration stored in its database and overwrites the changes done manually.
> 
> Activation of HAWQ Standby to active master involves manual command execution which updates the configuration files. In order to keep the configuration in sync and reflect the correct state of the HAWQ components on Ambari, we need to introduce a wizard, i.e *“Activate HAWQ Standby Wizard”*. 
> 
> This wizard will also automate the process of activating standby and the user now will need to walk-through the wizard to activate standby. 
> 
> #Overview of activate standby operation:
> * In HA configuration, HAWQ is configured with a master and standby component. 
> * To activate / promote standby to a master, “hawq activate standby” command needs to be executed on the standby
> * This operation updates the value of hawq_master_address_host and hawq_standby_address_host properties available in hawq-site.xml to below
>    1. hawq_master_address_host : Initially Configured HAWQ Standby Host
>    2. hawq_standby_address_host : This property is removed.
> * After the operation is completed, HAWQ cluster will be running in non-ha mode and will  not have a configured standby.
> 
> #Overview of the wizard pages and operation performed:
> The wizard consists of 3 pages, a brief of them is as below:
> 
> * “Get Started”: This page is the first page seen by the user, and it gives introduction of the activity going to be performed. 
> * “Review”: This page is the second page which informs the user about the changes which will happen. A confirmation is requested before proceeding to the next step.
> * “Finalize Setup”: This page is the third and last page which shows the progress for the steps executed. It does the below:
>     1. Execute command to activate HAWQ standby
>     2. Stop HAWQ service
>     3. Reconfigure HAWQ to push updated configs
>         * hawq_standby_address_host is removed
>         * hawq_master_address_host is updated to previous standby
>     4. Install HAWQ Master Ambari Component on the Standby Host
>     5. Delete HAWQ Standby Ambari Component on the Standby Host
>     6. Delete HAWQ Master Ambari Component on the Master host
>     7. Start HAWQ Service
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/assets/test/tests.js 215a754 
>   ambari-web/app/controllers.js eed54dc 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step1_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step2_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/step3_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/activateStandby/wizard_controller.js PRE-CREATION 
>   ambari-web/app/controllers/main/admin/highAvailability_controller.js 29ce167 
>   ambari-web/app/controllers/main/service/item.js b8ad011 
>   ambari-web/app/data/HDP2.3/hawq_activate_standby_properties.js PRE-CREATION 
>   ambari-web/app/data/controller_route.js 15e89a6 
>   ambari-web/app/messages.js d6ecbf3 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js 02cd36a 
>   ambari-web/app/models/host_component.js b205d38 
>   ambari-web/app/routes/activate_hawq_standby_routes.js PRE-CREATION 
>   ambari-web/app/routes/main.js 48c9b91 
>   ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step1.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step2.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step3.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/wizard.hbs PRE-CREATION 
>   ambari-web/app/utils/configs/hawq_activate_standby_config_initializer.js PRE-CREATION 
>   ambari-web/app/utils/configs/hawq_ha_config_initializer.js 1de2551 
>   ambari-web/app/utils/db.js 598910a 
>   ambari-web/app/views.js d3c7fdc 
>   ambari-web/app/views/main/admin/highAvailability/hawq/activateStandby/step1_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/highAvailability/hawq/activateStandby/step2_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/highAvailability/hawq/activateStandby/step3_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/highAvailability/hawq/activateStandby/wizard_view.js PRE-CREATION 
>   ambari-web/app/views/main/service/item.js 048c163 
>   ambari-web/test/controllers/main/admin/highAvailability/hawq/activateStandby/step2_controller_test.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43007/diff/
> 
> 
> Testing
> -------
> 
> yes manual and test case added.
> 
> mvn test:
> 
>   23120 tests complete (26 seconds)
>   166 tests pending
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>