You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/12 02:48:58 UTC

[GitHub] [spark] sarutak commented on pull request #31108: [SPARK-34058][UI] Add button to show/hide all stage details

sarutak commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-758358923


   Hi @brandonJY , I have three comments.
   
   1.  I tried this change but it doesn't work on my environment (Pop!_OS, an Ubuntu variant, and Firefox). When I click the button you added, I get the following error on the browser's console.
   ![errorn-on-click](https://user-images.githubusercontent.com/4736016/104262487-0beb5b00-54cb-11eb-8033-e32db90b2381.png)
   
   2. At first, I couldn't notice where is the button. Users might not notice it's a button.
   
   3. Could you add the screenshots for before/after press the button.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org