[GitHub] [accumulo] EdColeman commented on a diff in pull request #3482: Create tserver.group, add group to location information

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3482:
URL: https://github.com/apache/accumulo/pull/3482#discussion_r1226795653


##########
server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java:
##########
@@ -170,15 +170,15 @@ protected String getLocationFamily(LocationType type) {
   @Override
   public T putLocation(Location location) {
     Preconditions.checkState(updatesEnabled, "Cannot make updates after calling mutate.");
-    mutation.put(getLocationFamily(location.getType()), location.getSession(),
-        location.getHostPort());
+    mutation.put(getLocationFamily(location.getType()), "",
+        location.getServerInstance().toString());

Review Comment:
   Not sure if session id applies here, but my impression is that session id was used to detect client ZooKeeper re-connections.  If a ZooKeeper session failed (did not respond with ZooKeeper tick time), but then established a "new" connection - the change in session id was detected to signal that there is a possibility that information in ZooKeeper could have changed while the session was "off-line".  This may be a ZooCache centered view, but maybe it applied here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org