You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/19 11:59:18 UTC
[GitHub] [incubator-nuttx] lucasssvaz opened a new pull request, #7361: esp32/i2c: Add macros to conform with other peripherals and fix typos
lucasssvaz opened a new pull request, #7361:
URL: https://github.com/apache/incubator-nuttx/pull/7361
## Summary
Added missing macros to the I2C files for the ESP32. Also fixed some typos.
## Impact
None
## Testing
Tested the macros by initializing devices that use I2C.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #7361: esp32/i2c: Add macros to conform with other peripherals and fix typos
Posted by GitBox <gi...@apache.org>.
acassis merged PR #7361:
URL: https://github.com/apache/incubator-nuttx/pull/7361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7361: esp32/i2c: Add macros to conform with other peripherals and fix typos
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7361:
URL: https://github.com/apache/incubator-nuttx/pull/7361#discussion_r999515265
##########
arch/xtensa/src/esp32/esp32_i2c.h:
##########
@@ -43,6 +43,14 @@ extern "C"
#define EXTERN extern
#endif
+#ifdef CONFIG_ESP32_I2C0
+ #define ESP32_I2C0 0
Review Comment:
```suggestion
# define ESP32_I2C0 0
```
##########
arch/xtensa/src/esp32/esp32_i2c.h:
##########
@@ -43,6 +43,14 @@ extern "C"
#define EXTERN extern
#endif
+#ifdef CONFIG_ESP32_I2C0
+ #define ESP32_I2C0 0
+#endif /* CONFIG_ESP32_I2C0 */
+
+#ifdef CONFIG_ESP32_I2C1
+ #define ESP32_I2C1 1
Review Comment:
```suggestion
# define ESP32_I2C1 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org