[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9622: fix: add missing config in google cloud logging plugin

["monkeyDluffy6017 (via GitHub)" <gi...@apache.org>]

monkeyDluffy6017 commented on code in PR #9622:
URL: https://github.com/apache/apisix/pull/9622#discussion_r1226145051


##########
apisix/plugins/google-cloud-logging.lua:
##########
@@ -62,7 +63,7 @@ local schema = {
                     default = "https://logging.googleapis.com/v2/entries:write"
                 },
             },
-            required = { "private_key", "project_id", "token_uri" }
+            required = { "client_email", "private_key", "project_id", "token_uri" }

Review Comment:
   Could you show me the official doc that the google cloud logging need the `client_email`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org