You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Jake Mannix (Created) (JIRA)" <ji...@apache.org> on 2011/11/17 08:18:51 UTC
[jira] [Created] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Start using newly acquired reviewboard instance!
------------------------------------------------
Key: MAHOUT-888
URL: https://issues.apache.org/jira/browse/MAHOUT-888
Project: Mahout
Issue Type: Wish
Affects Versions: 0.6
Reporter: Jake Mannix
Priority: Minor
Fix For: 0.6
It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "Jake Mannix (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151878#comment-13151878 ]
Jake Mannix commented on MAHOUT-888:
------------------------------------
not sure how to get this to automatically notice that https://reviews.apache.org/r/2872/ was linked to this ticket...
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151880#comment-13151880 ]
jiraposter@reviews.apache.org commented on MAHOUT-888:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2872/#review3314
-----------------------------------------------------------
trunk/README.txt
<https://reviews.apache.org/r/2872/#comment7401>
Scary trailing whitespace at the end of this line! Whitespace nazis would comment here telling me to kill it.
trunk/README.txt
<https://reviews.apache.org/r/2872/#comment7402>
more trailing whitespace!
- Jake
On 2011-11-17 07:21:10, Jake Mannix wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2872/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-17 07:21:10)
bq.
bq.
bq. Review request for mahout.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888
bq.
bq.
bq. This addresses bug MAHOUT-888.
bq. https://issues.apache.org/jira/browse/MAHOUT-888
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/README.txt 1203081
bq.
bq. Diff: https://reviews.apache.org/r/2872/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No code was changed, so no testing was done!
bq.
bq.
bq. Thanks,
bq.
bq. Jake
bq.
bq.
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151886#comment-13151886 ]
jiraposter@reviews.apache.org commented on MAHOUT-888:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2872/#review3317
-----------------------------------------------------------
Ship it!
Sure. Why not.
- Ted
On 2011-11-17 07:21:10, Jake Mannix wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2872/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-17 07:21:10)
bq.
bq.
bq. Review request for mahout.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888
bq.
bq.
bq. This addresses bug MAHOUT-888.
bq. https://issues.apache.org/jira/browse/MAHOUT-888
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/README.txt 1203081
bq.
bq. Diff: https://reviews.apache.org/r/2872/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No code was changed, so no testing was done!
bq.
bq.
bq. Thanks,
bq.
bq. Jake
bq.
bq.
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151877#comment-13151877 ]
jiraposter@reviews.apache.org commented on MAHOUT-888:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2872/
-----------------------------------------------------------
Review request for mahout.
Summary
-------
This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888
This addresses bug MAHOUT-888.
https://issues.apache.org/jira/browse/MAHOUT-888
Diffs
-----
trunk/README.txt 1203081
Diff: https://reviews.apache.org/r/2872/diff
Testing
-------
No code was changed, so no testing was done!
Thanks,
Jake
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "Sean Owen (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-888.
------------------------------
Resolution: Fixed
Assignee: Jake Mannix
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151883#comment-13151883 ]
jiraposter@reviews.apache.org commented on MAHOUT-888:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2872/#review3315
-----------------------------------------------------------
Ship it!
After intensive and thorough inspection, I'd agree to commit this :)
- Sebastian
On 2011-11-17 07:21:10, Jake Mannix wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2872/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-17 07:21:10)
bq.
bq.
bq. Review request for mahout.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This diff is just of the README.txt, formatting it so that all lines are 80 characters or less, as an example diff for MAHOUT-888
bq.
bq.
bq. This addresses bug MAHOUT-888.
bq. https://issues.apache.org/jira/browse/MAHOUT-888
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/README.txt 1203081
bq.
bq. Diff: https://reviews.apache.org/r/2872/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. No code was changed, so no testing was done!
bq.
bq.
bq. Thanks,
bq.
bq. Jake
bq.
bq.
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "Jake Mannix (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151879#comment-13151879 ]
Jake Mannix commented on MAHOUT-888:
------------------------------------
nevermind, there it magically is, I was too impatient!
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAHOUT-888) Start using newly acquired
reviewboard instance!
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151978#comment-13151978 ]
Hudson commented on MAHOUT-888:
-------------------------------
Integrated in Mahout-Quality #1183 (See [https://builds.apache.org/job/Mahout-Quality/1183/])
'Fixes' MAHOUT-888 after two ship-it's
jmannix : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203092
Files :
* /mahout/trunk/README.txt
> Start using newly acquired reviewboard instance!
> ------------------------------------------------
>
> Key: MAHOUT-888
> URL: https://issues.apache.org/jira/browse/MAHOUT-888
> Project: Mahout
> Issue Type: Wish
> Affects Versions: 0.6
> Reporter: Jake Mannix
> Priority: Minor
> Fix For: 0.6
>
>
> It's easy: go to https://reviews.apache.org/ and submit a review by clicking "new review request", then picking the project to be "mahout", base directory to be "trunk", and upload your patch. Add "mahout" to the reviewer group of your reviewboard, pick some people you want to aim the review at (if you think you know the "owner" of the code area you're hitting), set the "bug number" in the appropriate field so that JIRA and RB will magically communicate, and don't forget to click the "publish" button when you're ready for people to look at it. You can also look at your review directly for sanity checking before doing so by clicking on the "view diff" button.
> ReviewBoard can be slow and clunky, but inline comments in the diff are A+ goodness.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira