[jira] [Commented] (THRIFT-4639) Sequence numbering for multiplexed protocol broken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647911#comment-16647911 ] 

ASF GitHub Bot commented on THRIFT-4639:
----------------------------------------

phlundblom commented on issue #1597: THRIFT-4639: Use correct sequence number for multiplexed protocol
URL: https://github.com/apache/thrift/pull/1597#issuecomment-429328856
 
 
   I honestly don't have time enough to dig into the the test cases. To me it actually seems like the NodeJS Thrift server implementation in one way or another is broken.
   
   I use NodeJS client against Java multiplexed server and that triggers completely different behaviors. Actually without this patch i get JS errors (`TypeError: this.seqid is not a function`) in NodeJS client rather than just the strange sequence number behaviors that appears when running unit tests against NodeJS server.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Sequence numbering for multiplexed protocol broken
> --------------------------------------------------
>
>                 Key: THRIFT-4639
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4639
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.11.0
>            Reporter: PH Lundblom
>            Priority: Blocker
>
> Handling of client sequence numbering for multiplexed protocol is broken.
> Current implementation uses client internal variable "seqid" which should be "_seqid"
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)