[GitHub] [tvm] sunshinemyson commented on a change in pull request #9046: Support verisilicon's NPU with BYOC framework

[GitBox <gi...@apache.org>]

sunshinemyson commented on a change in pull request #9046:
URL: https://github.com/apache/tvm/pull/9046#discussion_r713967852



##########
File path: cmake/modules/contrib/VsiNpu.cmake
##########
@@ -0,0 +1,30 @@
+if(NOT USE_VSI_NPU STREQUAL "OFF")

Review comment:
       I'll fix it.

##########
File path: cmake/modules/contrib/VsiNpu.cmake
##########
@@ -0,0 +1,30 @@
+if(NOT USE_VSI_NPU STREQUAL "OFF")
+
+if(NOT TIM_VX_INSTALL_DIR OR NOT EXISTS ${TIM_VX_INSTALL_DIR})
+message(FATAL_ERROR "TIM_VX_INSTALL_DIR should be set")
+endif()
+
+set(OVXLIB_API_ATTR "__attribute__\(\(visibility\(\"default\"\)\)\)")
+add_definitions(-DOVXLIB_API=${OVXLIB_API_ATTR})

Review comment:
       this is not required. Will remove it.

##########
File path: python/tvm/relay/op/contrib/vsi_npu_ffi_api.py
##########
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import tvm._ffi
+
+tvm._ffi._init_api("relay.vsi_npu.support", __name__)

Review comment:
       will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org